babel-plugin-makepot: Fix non-existing translation handling #49431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
5 tasks
sgomes
approved these changes
Mar 29, 2023
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
I have tested it, it works great. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a bug where we're incorrectly handling non-existing translations.
Why?
We're fixing a regression that was introduced in #45946.
Original report by @sjinks:
How?
We're defaulting the missing translation to an empty object so it would properly be calculated as the same translation if all keys are missing, preserving the original behavior with
_.pickBy().Testing Instructions
_.pick()#45946.